Lots Of Trivia

It started with some minor cleanups: the error PROTOCOL_INVALID_LEN should be called PROTOCOL_ERROR_INVALID_LEN to match the other errors. That became changing PROTOCOL_ERROR to PROTOCOL_ECODE everywhere.

Then I noticed that the other constants which are part of the protocol should also be have the PROTOCOL_ prefix.

And I’ve switched from transaction, to trans, and finally ended up at “tx” as the abbreviation for transaction in the code. So let’s use tx everywhere.

Three dead code removal patches, and one patch to remove an unused struct field.

Two minor code moves.

I wrote a new structeq ccan module, and used it.

I did write one new unit test, and added a valgrind suppressions file for openssl so I could reenable valgrind leak detection.

Finally, this evening, since I wanted to get all the trivia out of the way at once, I renamed marshall to marshal.